> On Oct. 26, 2014, 1:11 a.m., Benjamin Hindman wrote: > > src/tests/docker_containerizer_tests.cpp, line 111 > > <https://reviews.apache.org/r/26862/diff/5/?file=728445#file728445line111> > > > > This doesn't look like it was used by any call sites.
Good catch, I'm still going to use this to check if a docker container is still running. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26862/#review58545 ----------------------------------------------------------- On Oct. 22, 2014, 12:46 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26862/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2014, 12:46 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Docker tests are flaky, mostly around getting expected output from the docker > container forwarded to stdout/stderr. > > This is due to Docker not always have the stdout/stderr output available for > docker logs if kill/rm is called. > > > Diffs > ----- > > src/docker/docker.hpp 9656f15 > src/docker/docker.cpp e09b51c > src/slave/containerizer/docker.hpp fbbd45d > src/slave/containerizer/docker.cpp 9a29489 > src/tests/docker_containerizer_tests.cpp 67d60a8 > src/tests/docker_tests.cpp 04139af > src/tests/environment.cpp 4dd78e7 > > Diff: https://reviews.apache.org/r/26862/diff/ > > > Testing > ------- > > make with gtest_repeat=-1 gtest_shuffle=1 > > > Thanks, > > Timothy Chen > >
