----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26862/#review59405 -----------------------------------------------------------
Ship it! src/docker/docker.hpp <https://reviews.apache.org/r/26862/#comment100671> One parameter per line please. Did you need to wrap this though? src/slave/containerizer/docker.hpp <https://reviews.apache.org/r/26862/#comment100672> s/memory::shared_ptr/Shared/ You'll need to include "process/shared.hpp". src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/26862/#comment100673> One argument per line please. src/tests/docker_containerizer_tests.cpp <https://reviews.apache.org/r/26862/#comment100678> Shouldn't this one not be a MockDocker? src/tests/docker_containerizer_tests.cpp <https://reviews.apache.org/r/26862/#comment100692> FutureResult(&logs, Invoke(docker.get(), &MockDocker::_logs)); - Benjamin Hindman On Oct. 29, 2014, 12:21 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26862/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2014, 12:21 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Docker tests are flaky, mostly around getting expected output from the docker > container forwarded to stdout/stderr. > > This is due to Docker not always have the stdout/stderr output available for > docker logs if kill/rm is called. > > > Diffs > ----- > > src/docker/docker.hpp 9656f15 > src/docker/docker.cpp 9973782 > src/slave/containerizer/docker.hpp fbbd45d > src/slave/containerizer/docker.cpp 9a29489 > src/tests/docker_containerizer_tests.cpp 67d60a8 > src/tests/docker_tests.cpp 04139af > src/tests/environment.cpp 4dd78e7 > > Diff: https://reviews.apache.org/r/26862/diff/ > > > Testing > ------- > > make with gtest_repeat=-1 gtest_shuffle=1 > > > Thanks, > > Timothy Chen > >
