> On Oct. 29, 2014, 2:17 a.m., Cody Maloney wrote: > > src/slave/containerizer/docker.cpp, line 266 > > <https://reviews.apache.org/r/26517/diff/5/?file=736740#file736740line266> > > > > I get why this cleanup should be in the destructor, but it feels uneven > > that we do the cleanup in the destructor but we don't do the creation / > > symlink in the constructor. > > > > Destructors should roughly reverse constructors.
Since creating symlink might get an error, we can't do this in the constructor. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26517/#review58938 ----------------------------------------------------------- On Oct. 29, 2014, 12:25 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26517/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2014, 12:25 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1833 > https://issues.apache.org/jira/browse/MESOS-1833 > > > Repository: mesos-git > > > Description > ------- > > Review: https://reviews.apache.org/r/26517 > > > Diffs > ----- > > src/slave/containerizer/docker.hpp fbbd45d > src/slave/containerizer/docker.cpp 9a29489 > src/tests/docker_containerizer_tests.cpp 67d60a8 > > Diff: https://reviews.apache.org/r/26517/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
