----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26517/#review59392 -----------------------------------------------------------
Ship it! src/slave/containerizer/docker.hpp <https://reviews.apache.org/r/26517/#comment100659> s/cli/CLI/ src/slave/containerizer/docker.hpp <https://reviews.apache.org/r/26517/#comment100658> s/DIR/DIRECTORY/ src/tests/docker_containerizer_tests.cpp <https://reviews.apache.org/r/26517/#comment100661> Why do you need this? Shouldn't the DockerContainerizerProcess properly create this for you? - Benjamin Hindman On Oct. 29, 2014, 3 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26517/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2014, 3 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1833 > https://issues.apache.org/jira/browse/MESOS-1833 > > > Repository: mesos-git > > > Description > ------- > > Review: https://reviews.apache.org/r/26517 > > > Diffs > ----- > > src/slave/containerizer/docker.hpp fbbd45d > src/slave/containerizer/docker.cpp 9a29489 > src/tests/docker_containerizer_tests.cpp 67d60a8 > > Diff: https://reviews.apache.org/r/26517/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
