----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27556/#review59808 -----------------------------------------------------------
What's our policy on newlines between the options? For the combined master / slave options there are newlines separating each but for the separate master and slave it's inconsistent. I see you've cleaned up some but there are a few remaining, e.g., after --credentials=VALUE. I personally think a newline helps visibility but whatever we decide we should be consistent. - Ian Downes On Nov. 4, 2014, 8:15 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27556/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2014, 8:15 a.m.) > > > Review request for mesos, Ian Downes and Till Toenshoff. > > > Bugs: MESOS-2037 > https://issues.apache.org/jira/browse/MESOS-2037 > > > Repository: mesos-git > > > Description > ------- > > Copied the output of --help messages from configure, master, and slave. > > > Diffs > ----- > > docs/configuration.md 5845ae324181d01cb65990fbf8dd38a621e1c351 > > Diff: https://reviews.apache.org/r/27556/diff/ > > > Testing > ------- > > Pushed and tested output on github at: > https://github.com/karya0/mesos/blob/modules/docs/configuration.md > > > Thanks, > > Kapil Arya > >
