> On Nov. 4, 2014, 2:42 p.m., Ian Downes wrote: > > What's our policy on newlines between the options? > > > > For the combined master / slave options there are newlines separating each > > but for the separate master and slave it's inconsistent. I see you've > > cleaned up some but there are a few remaining, e.g., after > > --credentials=VALUE. > > > > I personally think a newline helps visibility but whatever we decide we > > should be consistent.
The current one is pasted verbatim from the help messages. I did see that there is some inconsistency in the help message output as well (new line after --credentials, --offer_timeout for master, and --containerizer_path, --default_container_image for slave). I can create a separate review request to remove those newlines from the --help message. Further, I also think that we should put newlines in the configuration.md file but not in the --help text. Having said that, is there some place where we can put this policy? - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27556/#review59808 ----------------------------------------------------------- On Nov. 4, 2014, 11:15 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27556/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2014, 11:15 a.m.) > > > Review request for mesos, Ian Downes and Till Toenshoff. > > > Bugs: MESOS-2037 > https://issues.apache.org/jira/browse/MESOS-2037 > > > Repository: mesos-git > > > Description > ------- > > Copied the output of --help messages from configure, master, and slave. > > > Diffs > ----- > > docs/configuration.md 5845ae324181d01cb65990fbf8dd38a621e1c351 > > Diff: https://reviews.apache.org/r/27556/diff/ > > > Testing > ------- > > Pushed and tested output on github at: > https://github.com/karya0/mesos/blob/modules/docs/configuration.md > > > Thanks, > > Kapil Arya > >
