----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27843/#review60816 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/27843/#comment102229> Hmm. Not sure why ended up using Error() instead of string? The string version was concise and readable. AFAICT, there were only couple places where we had to do stringify() if the compiler didn't recognize it was a string. src/master/master.cpp <https://reviews.apache.org/r/27843/#comment102225> why pull this down? src/master/master.cpp <https://reviews.apache.org/r/27843/#comment102227> Put "(Actual:" on next line. it is more readable that way. src/master/master.cpp <https://reviews.apache.org/r/27843/#comment102231> why does the order matter? maybe expand on the comment? src/tests/resource_offers_tests.cpp <https://reviews.apache.org/r/27843/#comment102226> you can kill this. - Vinod Kone On Nov. 10, 2014, 11:41 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27843/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2014, 11:41 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Simply the task validation logic by moving all resources usage validation > into ResourceUsageChecker. > > > Diffs > ----- > > src/master/master.hpp 687f178 > src/master/master.cpp 0e182a6 > src/tests/resource_offers_tests.cpp ee332c3 > > Diff: https://reviews.apache.org/r/27843/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
