> On Nov. 11, 2014, 7:25 p.m., Vinod Kone wrote:
> > src/master/master.cpp, line 1889
> > <https://reviews.apache.org/r/27843/diff/1/?file=757343#file757343line1889>
> >
> > Hmm. Not sure why ended up using Error() instead of string? The string
> > version was concise and readable. AFAICT, there were only couple places
> > where we had to do stringify() if the compiler didn't recognize it was a
> > string.
The return value of this function is Option<Error>. So, it would be more
readable and explicit to use Error("xxx") here. Also, some of the OfferCheckers
return Error, so I want it to be consistent.
Using string as the return value is a bit confusing to me.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27843/#review60816
-----------------------------------------------------------
On Nov. 10, 2014, 11:41 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27843/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2014, 11:41 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Simply the task validation logic by moving all resources usage validation
> into ResourceUsageChecker.
>
>
> Diffs
> -----
>
> src/master/master.hpp 687f178
> src/master/master.cpp 0e182a6
> src/tests/resource_offers_tests.cpp ee332c3
>
> Diff: https://reviews.apache.org/r/27843/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
