> On Nov. 15, 2014, 7:17 p.m., Ben Mahler wrote: > > include/mesos/resources.hpp, lines 66-69 > > <https://reviews.apache.org/r/28078/diff/2/?file=764753#file764753line66> > > > > IMO this was a bit more organized before: > > > > ``` > > + > > - > > > > += > > -= > > ``` > > > > If you want to organize by +/- how about: > > > > ``` > > + > > += > > > > - > > -= > > ``` > > > > For some reason, += after + seems easier to read.
Done. > On Nov. 15, 2014, 7:17 p.m., Ben Mahler wrote: > > include/mesos/resources.hpp, lines 289-292 > > <https://reviews.apache.org/r/28078/diff/2/?file=764753#file764753line289> > > > > Ditto here, maybe + before +=? Done. > On Nov. 15, 2014, 7:17 p.m., Ben Mahler wrote: > > include/mesos/resources.hpp, lines 297-300 > > <https://reviews.apache.org/r/28078/diff/2/?file=764753#file764753line297> > > > > Ditto here, maybe - before -=? Done. > On Nov. 15, 2014, 7:17 p.m., Ben Mahler wrote: > > include/mesos/resources.hpp, lines 312-317 > > <https://reviews.apache.org/r/28078/diff/2/?file=764753#file764753line312> > > > > Could we get away with only needing <iosfwd> if we move this into the > > .cpp file? I think <iostream> is pretty heavyweight: > > > > ``` > > $ time g++ iostream.cpp > > g++ iostream.cpp 0.19s user 0.03s system 98% cpu 0.225 total > > $ time g++ iosfwd.cpp > > g++ iosfwd.cpp 0.03s user 0.02s system 93% cpu 0.054 total > > ``` > > > > This is after several runs to warm the file cache. > > Michael Park wrote: > +1 for `<iosfwd>`. As mentioned in https://reviews.apache.org/r/28092/, > we can just kill this function entirely. OK, I'll do it in the later in a later review. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28078/#review61653 ----------------------------------------------------------- On Nov. 15, 2014, 6:43 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28078/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2014, 6:43 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1974 > https://issues.apache.org/jira/browse/MESOS-1974 > > > Repository: mesos-git > > > Description > ------- > > See summary and ticket. This patch does not change any code (just code > movement). > > > Diffs > ----- > > include/mesos/resources.hpp 0e37170262d3470570a3436b7835bb1d4a121056 > src/common/resources.cpp e9a0c85dc3748aa635843d98cd5993d5648ec5c2 > > Diff: https://reviews.apache.org/r/28078/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
