----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28078/#review61822 -----------------------------------------------------------
Ship it! src/common/resources.cpp <https://reviews.apache.org/r/28078/#comment103733> have we decided to not include headers included in the related header file? i still like the explicitness of including all the headers that the source file needs. doesn't need non-local reasoning. - Vinod Kone On Nov. 17, 2014, 8:29 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28078/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2014, 8:29 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1974 > https://issues.apache.org/jira/browse/MESOS-1974 > > > Repository: mesos-git > > > Description > ------- > > See summary and ticket. This patch does not change any code (just code > movement). > > > Diffs > ----- > > include/mesos/resources.hpp 0e37170262d3470570a3436b7835bb1d4a121056 > src/common/resources.cpp e9a0c85dc3748aa635843d98cd5993d5648ec5c2 > > Diff: https://reviews.apache.org/r/28078/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
