> On Nov. 17, 2014, 9:38 p.m., Timothy Chen wrote: > > include/mesos/mesos.proto, line 601 > > <https://reviews.apache.org/r/28154/diff/1/?file=766841#file766841line601> > > > > I feel like parameters as the field name on TaskInfo made it sounds > > like the parameters required to run this task, but instead it's more > > metadata or labels about a task. > > I like your original ticket where you called it labels, you agree?
I agree - I like 'labels' better, but `optional Parameters labels` reads a bit weird to me, and using it: task.mutable_labels()->add_parameter(); Is confusing too. So I am a bit torn; I like 'labels' but would like not to duplicate a concept we already have. - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28154/#review61882 ----------------------------------------------------------- On Nov. 17, 2014, 8:13 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28154/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2014, 8:13 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-2120 > https://issues.apache.org/jira/browse/MESOS-2120 > > > Repository: mesos-git > > > Description > ------- > > See description. > > > Diffs > ----- > > include/mesos/mesos.proto 35b91180f4e317c47dfdd18e9f7fca28143ae8f5 > > Diff: https://reviews.apache.org/r/28154/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
