> On Nov. 18, 2014, 9:12 a.m., Dominic Hamon wrote: > > include/mesos/mesos.proto, line 601 > > <https://reviews.apache.org/r/28154/diff/1/?file=766841#file766841line601> > > > > where is this Parameters struct defined? > > > > should it be > > repeated Parameter parameters > > > > to be clear that it's repeated?
Here https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L712 and already have a repeated field of key value pairs. - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28154/#review61938 ----------------------------------------------------------- On Nov. 17, 2014, 8:13 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28154/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2014, 8:13 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-2120 > https://issues.apache.org/jira/browse/MESOS-2120 > > > Repository: mesos-git > > > Description > ------- > > See description. > > > Diffs > ----- > > include/mesos/mesos.proto 35b91180f4e317c47dfdd18e9f7fca28143ae8f5 > > Diff: https://reviews.apache.org/r/28154/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
