> On Nov. 18, 2014, 2:52 p.m., Timothy Chen wrote: > > src/common/http.cpp, line 133 > > <https://reviews.apache.org/r/28155/diff/2/?file=768091#file768091line133> > > > > Actually looking at the labels representation, it's much truly > > represented as a list of labels, instead of a json object. > > > > I believe this is much more flexible as users can add multiple values > > for the same label key, and also we can add more fields if needed to label > > and our repesentation doesn't change as much.
Great point - change coming up. - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28155/#review62040 ----------------------------------------------------------- On Nov. 18, 2014, 2:39 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28155/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2014, 2:39 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-2120 > https://issues.apache.org/jira/browse/MESOS-2120 > > > Repository: mesos-git > > > Description > ------- > > See description. > > > Diffs > ----- > > src/common/http.cpp 58050e9534045ec3e8b74dd0214b1b12d5ff8ea7 > > Diff: https://reviews.apache.org/r/28155/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
