> On Nov. 19, 2014, 10:58 a.m., Ben Mahler wrote: > > src/common/http.cpp, lines 133-140 > > <https://reviews.apache.org/r/28155/diff/3/?file=768238#file768238line133> > > > > I'm curious, was JSON::Protobuf not sufficient here? > > > > ``` > > JSON::Array labels; > > foreach (const Label& label, task.labels()) { > > labels.values.push_back(JSON::Protobuf(label)); > > } > > object.values["labels"] = labels; > > ``` > > > > Ditto below.
No need - great suggestion! https://reviews.apache.org/r/28287/ - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28155/#review62191 ----------------------------------------------------------- On Nov. 18, 2014, 4:07 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28155/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2014, 4:07 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-2120 > https://issues.apache.org/jira/browse/MESOS-2120 > > > Repository: mesos-git > > > Description > ------- > > See description. > > > Diffs > ----- > > src/common/http.cpp 58050e9534045ec3e8b74dd0214b1b12d5ff8ea7 > > Diff: https://reviews.apache.org/r/28155/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
