> On Nov. 19, 2014, 12:45 a.m., Benjamin Hindman wrote: > > include/mesos/mesos.proto, line 937 > > <https://reviews.apache.org/r/28154/diff/3/?file=768237#file768237line937> > > > > Why no Labels like Parameters? > > > > The reason we've had these in the past is then we don't have to pass > > around RepeatedPtrField<Label> in the codebase.
I see, I didn't think it was necessary given it's use case, like we don't have Variables type for Variable. If we see the need to pass around labels we can certainly create one. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28154/#review62080 ----------------------------------------------------------- On Nov. 19, 2014, 12:06 a.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28154/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 12:06 a.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-2120 > https://issues.apache.org/jira/browse/MESOS-2120 > > > Repository: mesos-git > > > Description > ------- > > See description. > > > Diffs > ----- > > include/mesos/mesos.proto 35b91180f4e317c47dfdd18e9f7fca28143ae8f5 > > Diff: https://reviews.apache.org/r/28154/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
