----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28287/#review62384 -----------------------------------------------------------
Ship it! Moving to JSON::Protobuf requires that we strictly enforce the format as part of the tests, to avoid accidentally breaking the http api. Just to confirm, would the tests break if the Label protobuf is changed? If not, let's make sure a test will catch it. - Ben Mahler On Nov. 20, 2014, 6:20 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28287/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2014, 6:20 p.m.) > > > Review request for mesos, Ben Mahler and Timothy Chen. > > > Repository: mesos-git > > > Description > ------- > > JSON fields doesn't need to be set explicitly, so label modeling can be > simplified with JSON::Protobuf. > > > Diffs > ----- > > src/common/http.cpp b21e18d547d716e540dc2ce47b2cb1ab898bce94 > > Diff: https://reviews.apache.org/r/28287/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
