> On Nov. 20, 2014, 11:03 a.m., Ben Mahler wrote: > > Moving to JSON::Protobuf requires that we strictly enforce the format as > > part of the tests, to avoid accidentally breaking the http api. Just to > > confirm, would the tests break if the Label protobuf is changed? If not, > > let's make sure a test will catch it. > > Niklas Nielsen wrote: > Right now, the tests only verifies known fields: > https://github.com/apache/mesos/blob/master/src/tests/master_tests.cpp#L2662 > So would it be more robust to test as we do in HTTP.ModelTask? I can do > that in a subsequent review.
https://reviews.apache.org/r/28293/ and https://reviews.apache.org/r/28294/ - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28287/#review62384 ----------------------------------------------------------- On Nov. 20, 2014, 11:32 a.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28287/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2014, 11:32 a.m.) > > > Review request for mesos, Ben Mahler and Timothy Chen. > > > Repository: mesos-git > > > Description > ------- > > JSON fields doesn't need to be set explicitly, so label modeling can be > simplified with JSON::Protobuf. > > > Diffs > ----- > > src/common/http.cpp b21e18d547d716e540dc2ce47b2cb1ab898bce94 > > Diff: https://reviews.apache.org/r/28287/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
