----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28258/#review62413 -----------------------------------------------------------
Ship it! src/common/resources.cpp <https://reviews.apache.org/r/28258/#comment104464> include 'resource.name()' in error message. src/common/resources.cpp <https://reviews.apache.org/r/28258/#comment104465> Error("Persistent disk volume " + resource.disk().persistence() + " is disallowed for '*' role"); src/common/resources.cpp <https://reviews.apache.org/r/28258/#comment104466> Error("Persistent disk " + resource.disk().persistence() + " should specify a volume"); - Vinod Kone On Nov. 19, 2014, 11:39 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28258/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 11:39 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, switched to > 'mcypark', and Vinod Kone. > > > Bugs: MESOS-2135 > https://issues.apache.org/jira/browse/MESOS-2135 > > > Repository: mesos-git > > > Description > ------- > > See summary. This is for single Resource object validation. > > > Diffs > ----- > > src/common/resources.cpp 61d16a88bb1300c343c4f3141d5a068dbba933bd > src/tests/resources_tests.cpp 73f50ba4f5c5db591180edd1fef1a3ecf6e03185 > > Diff: https://reviews.apache.org/r/28258/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
