> On Nov. 20, 2014, 8:45 p.m., Vinod Kone wrote: > > src/common/resources.cpp, line 314 > > <https://reviews.apache.org/r/28258/diff/3/?file=770561#file770561line314> > > > > include 'resource.name()' in error message.
How about: "DiskInfo should not be set for " + resource.name() + " resource" > On Nov. 20, 2014, 8:45 p.m., Vinod Kone wrote: > > src/common/resources.cpp, line 318 > > <https://reviews.apache.org/r/28258/diff/3/?file=770561#file770561line318> > > > > Error("Persistent disk volume " + resource.disk().persistence() + " is > > disallowed for '*' role"); Do we know how to print a 'Persistence', why would we bother printing the id? Ditto below. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28258/#review62413 ----------------------------------------------------------- On Nov. 19, 2014, 11:39 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28258/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 11:39 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, switched to > 'mcypark', and Vinod Kone. > > > Bugs: MESOS-2135 > https://issues.apache.org/jira/browse/MESOS-2135 > > > Repository: mesos-git > > > Description > ------- > > See summary. This is for single Resource object validation. > > > Diffs > ----- > > src/common/resources.cpp 61d16a88bb1300c343c4f3141d5a068dbba933bd > src/tests/resources_tests.cpp 73f50ba4f5c5db591180edd1fef1a3ecf6e03185 > > Diff: https://reviews.apache.org/r/28258/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
