> On Nov. 20, 2014, 7:54 p.m., Benjamin Hindman wrote: > > src/docker/docker.hpp, line 131 > > <https://reviews.apache.org/r/28190/diff/1/?file=768104#file768104line131> > > > > Why isn't s/forcePullImage/force/ sufficient for the parameter name? > > This function is called 'pull' and we know we're pulling an image, we just > > need to figure out if we should force it or not.
I originally did, but I remembered you wanted me to have the same consistent name from proto all the way to the variable name, so I just stuck with that :) - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28190/#review62399 ----------------------------------------------------------- On Nov. 19, 2014, 12:13 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28190/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 12:13 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1886 > https://issues.apache.org/jira/browse/MESOS-1886 > > > Repository: mesos-git > > > Description > ------- > > Add option to force pull docker image > > > Diffs > ----- > > include/mesos/mesos.proto 35b91180f4e317c47dfdd18e9f7fca28143ae8f5 > src/docker/docker.hpp f004879cab8524a5c765a42a2216f22e2e9a1f0a > src/docker/docker.cpp f2730a733fbabea90e9395de85c0668a29ccc530 > src/slave/containerizer/docker.hpp f9f3ffb5a407a34e7ec2dc317921d67cfeba1281 > src/slave/containerizer/docker.cpp 6213198f9ee6227d77461aef2b3a012d51b6535c > src/tests/docker_containerizer_tests.cpp > 59c2beb1907b4c6b5782b7c848c5c5116b9de272 > > Diff: https://reviews.apache.org/r/28190/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
