> On Nov. 19, 2014, 11:38 p.m., Niklas Nielsen wrote: > > include/mesos/mesos.proto, lines 255-256 > > <https://reviews.apache.org/r/28063/diff/2/?file=765850#file765850line255> > > > > Explain the effect of setting it - not how it is implemented :-) > > In other words, the current comment doesn't explain the semantics of > > the grace_period. > > > > The last fact about sharing executor between multiple tasks applies for > > everything in the executor info, so I would skip that part. The slave only > > matches on executor id. > > > > Lastly, we shouldn't even mention the executor here. Command info is > > just one place where the command info is potentially used.
Agreed. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28063/#review62276 ----------------------------------------------------------- On Nov. 17, 2014, 12:09 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28063/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2014, 12:09 p.m.) > > > Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff. > > > Bugs: MESOS-1571 > https://issues.apache.org/jira/browse/MESOS-1571 > > > Repository: mesos-git > > > Description > ------- > > CommandExecutor grace_period field is designed to be used by slave to > propagate the value of the grace period flag further to containerizers and > executors. > > > Diffs > ----- > > include/mesos/mesos.proto 35b9118 > src/slave/slave.hpp 29bea65 > src/slave/slave.cpp 06b2e18 > > Diff: https://reviews.apache.org/r/28063/diff/ > > > Testing > ------- > > make check (Mac OS 10.9.4, Ubuntu 14.04) > > > Thanks, > > Alexander Rukletsov > >
