----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28063/#review63475 -----------------------------------------------------------
src/slave/slave.hpp <https://reviews.apache.org/r/28063/#comment105737> /es/e/ src/slave/slave.cpp <https://reviews.apache.org/r/28063/#comment105739> Think I mentioned this before - drop 'updated' prefix. Has some of the previous patches been squashed into this one? src/slave/slave.cpp <https://reviews.apache.org/r/28063/#comment106037> 'do not' or 'do only'? src/slave/slave.cpp <https://reviews.apache.org/r/28063/#comment106038> Check for what? :) src/slave/slave.cpp <https://reviews.apache.org/r/28063/#comment106039> else if? If the task has a command, it cannot have an executor - Niklas Nielsen On Nov. 24, 2014, 9:07 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28063/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2014, 9:07 a.m.) > > > Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff. > > > Bugs: MESOS-1571 > https://issues.apache.org/jira/browse/MESOS-1571 > > > Repository: mesos-git > > > Description > ------- > > CommandExecutor grace_period field is designed to be used by slave to > propagate the value of the grace period flag further to containerizers and > executors. > > > Diffs > ----- > > include/mesos/mesos.proto 0085aba > src/slave/slave.hpp 70bd8c1 > src/slave/slave.cpp ed63ded > > Diff: https://reviews.apache.org/r/28063/diff/ > > > Testing > ------- > > make check (Mac OS 10.9.4, Ubuntu 14.04) > > > Thanks, > > Alexander Rukletsov > >
