----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28485/#review63178 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/include/process/node.hpp <https://reviews.apache.org/r/28485/#comment105355> s/Node &/Node& / and '{' on newline please. 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/28485/#comment105356> Let's be really explicit here too: return impl->bind(Node::LOCALHOST_ANY()); 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/28485/#comment105357> Let's change this to: __node__ = Node::LOCALHOST_ANY(); - Benjamin Hindman On Nov. 26, 2014, 10:50 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28485/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2014, 10:50 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > This makes it clearer when we intend to bind on a specific ip:port > (socket.bind(node)) and when we just want to bind to any local port > (socket.bind()). > > > Diffs > ----- > > 3rdparty/libprocess/include/process/node.hpp > 24132a5a9ff36a0fff3a25e7f7efce23777e3833 > 3rdparty/libprocess/include/process/socket.hpp > 3f3e01c7e9ecc52042c432212f697b69b3fde3b0 > 3rdparty/libprocess/src/process.cpp > 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3 > > Diff: https://reviews.apache.org/r/28485/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > >
