----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28485/#review63386 -----------------------------------------------------------
3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/28485/#comment105640> having an overload with a different inner Try might cause surprises at callsites. maybe return the bound node anyway to make things easier for users. 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/28485/#comment105641> this can be simplified if you have one bind call that always takes a node. Try<Node> bind = __s__.bind(__node__); if (bind.isError()) { PLOG(FATAL) << "Failed to initialize: " << bind.error(); } __node__ = bind.get(); - Dominic Hamon On Nov. 27, 2014, 10:36 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28485/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2014, 10:36 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > This makes it clearer when we intend to bind on a specific ip:port > (socket.bind(node)) and when we just want to bind to any local port > (socket.bind()). > > > Diffs > ----- > > 3rdparty/libprocess/include/process/node.hpp > 24132a5a9ff36a0fff3a25e7f7efce23777e3833 > 3rdparty/libprocess/include/process/socket.hpp > 3f3e01c7e9ecc52042c432212f697b69b3fde3b0 > 3rdparty/libprocess/src/process.cpp > 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3 > > Diff: https://reviews.apache.org/r/28485/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > >
