> On Dec. 1, 2014, 5:41 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/src/net.hpp, line 49 > > <https://reviews.apache.org/r/28545/diff/1/?file=778746#file778746line49> > > > > hm. i don't think we work that often with exceptions. maybe this should > > be reworked to return an Error instead.
Btw, do we still need the code from 3rdparty/libprocess/src/httpd.cpp and 3rdparty/libprocess/src/net.hpp? > On Dec. 1, 2014, 5:41 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/include/process/socket.hpp, line 41 > > <https://reviews.apache.org/r/28545/diff/1/?file=778743#file778743line41> > > > > why are these inline? If I remove inline, the linker complains abot this. > On Dec. 1, 2014, 5:41 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/include/process/socket.hpp, line 60 > > <https://reviews.apache.org/r/28545/diff/1/?file=778743#file778743line60> > > > > will this take a family eventually? might be worth taking it now. > > > > otherwise, will it try to do both ipv4 and ipv6? > > > > if you want, take a look at https://github.com/m-lab/libraries for one > > way to handle ipv4 and ipv6 sockets gracefully. Node will contain a field net::IP for the ip address. net::IP will contain the family type. - Evelina ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28545/#review63383 ----------------------------------------------------------- On Dec. 1, 2014, 4:30 a.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28545/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2014, 4:30 a.m.) > > > Review request for mesos, Dominic Hamon and Joris Van Remoortere. > > > Repository: mesos-git > > > Description > ------- > > Created accept, bind, connect and getsockname wrappers in socket.hpp for > different protocol families > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp > 3f3e01c7e9ecc52042c432212f697b69b3fde3b0 > 3rdparty/libprocess/src/http.cpp b00f33339366f5c06b6f20e38c5ae0c23b8a9358 > 3rdparty/libprocess/src/httpd.cpp 902ba89b18c5d7edf68ca9d17c55e5727529f96e > 3rdparty/libprocess/src/net.hpp 7bf6085e1bd9ffa0e42a5da9c3567521ff4c0713 > 3rdparty/libprocess/src/process.cpp > 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3 > 3rdparty/libprocess/src/tests/http_tests.cpp > a90e65f77904da0a45e1cc0cc9889ae69354a1a5 > 3rdparty/libprocess/src/tests/process_tests.cpp > dec62e88ec993433e1a0777593bb2657b43636dc > > Diff: https://reviews.apache.org/r/28545/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
