> On Dec. 2, 2014, 10:04 a.m., Dominic Hamon wrote: > > 3rdparty/libprocess/include/process/socket.hpp, line 69 > > <https://reviews.apache.org/r/28545/diff/2/?file=779866#file779866line69> > > > > add a family - may as well get used to it. > > Evelina Dumitrescu wrote: > Wouldn't it be better if I leave this as it is? I was thinking that Node > will contain a field net::IP for the ip address and net::IP will contain the > family type. I have written this also on the previous revision.
ok > On Dec. 2, 2014, 10:04 a.m., Dominic Hamon wrote: > > 3rdparty/libprocess/src/net.hpp, line 47 > > <https://reviews.apache.org/r/28545/diff/2/?file=779869#file779869line47> > > > > you're in the process namespace. > > Evelina Dumitrescu wrote: > I don't see any namespace process declared here. huh. you're right. that's probably an oversight that we should correct to avoid polluting the global namespace. another patch though :) > On Dec. 2, 2014, 10:04 a.m., Dominic Hamon wrote: > > 3rdparty/libprocess/src/net.hpp, line 73 > > <https://reviews.apache.org/r/28545/diff/2/?file=779869#file779869line73> > > > > this cast makes me uncomfortable. should the Node constructor take an > > in_addr? > > Evelina Dumitrescu wrote: > Sure, I will add another patch for this. But it will be replaced soon by > net::IP. if you have a plan to replace it, then don't worry. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28545/#review63554 ----------------------------------------------------------- On Dec. 3, 2014, 6:16 a.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28545/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 6:16 a.m.) > > > Review request for mesos, Dominic Hamon and Joris Van Remoortere. > > > Repository: mesos-git > > > Description > ------- > > Created accept, bind, connect and getsockname wrappers in socket.hpp for > different protocol families > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp > ab080c154095029c4a01d189a5fd8a178ba6c92e > 3rdparty/libprocess/src/http.cpp b00f33339366f5c06b6f20e38c5ae0c23b8a9358 > 3rdparty/libprocess/src/httpd.cpp 902ba89b18c5d7edf68ca9d17c55e5727529f96e > 3rdparty/libprocess/src/net.hpp 7bf6085e1bd9ffa0e42a5da9c3567521ff4c0713 > 3rdparty/libprocess/src/process.cpp > 4db7d56af710577e08a9d7dbeb92a1f01559401f > 3rdparty/libprocess/src/tests/http_tests.cpp > a90e65f77904da0a45e1cc0cc9889ae69354a1a5 > 3rdparty/libprocess/src/tests/process_tests.cpp > dec62e88ec993433e1a0777593bb2657b43636dc > > Diff: https://reviews.apache.org/r/28545/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
