----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28323/#review63719 -----------------------------------------------------------
3rdparty/libprocess/src/libevent_poll.cpp <https://reviews.apache.org/r/28323/#comment106005> cb for callback - we usually don't abbreviate function names. What do you think about spelling it out? 3rdparty/libprocess/src/libevent_poll.cpp <https://reviews.apache.org/r/28323/#comment106002> I have a bit of a hard time understanding this - can you expand/comment on what's going on? 3rdparty/libprocess/src/libevent_poll.cpp <https://reviews.apache.org/r/28323/#comment106000> Looks a bit odd to me; should it be single newline? 3rdparty/libprocess/src/libevent_poll.cpp <https://reviews.apache.org/r/28323/#comment106003> Same as above 3rdparty/libprocess/src/libevent_poll.cpp <https://reviews.apache.org/r/28323/#comment106004> s/nullptr/NULL/ - Niklas Nielsen On Dec. 3, 2014, 11:50 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28323/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 11:50 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa > 3rdparty/libprocess/src/libevent_poll.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/28323/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
