----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28323/#review63919 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/src/libevent_poll.cpp <https://reviews.apache.org/r/28323/#comment106248> { on newline please. 3rdparty/libprocess/src/libevent_poll.cpp <https://reviews.apache.org/r/28323/#comment106250> Do we need the 'struct'? I've seen this a few times, so please do a sweep of these reviews and remove them if possible. (I do know of one place where we need it because libev uses the same name for a struct and a function). 3rdparty/libprocess/src/libevent_poll.cpp <https://reviews.apache.org/r/28323/#comment106259> Let's s/auto/Future<short>/ for now, thanks! 3rdparty/libprocess/src/libevent_poll.cpp <https://reviews.apache.org/r/28323/#comment106260> How about: poll->ev = event_new(...); Then use poll->ev everywhere. - Benjamin Hindman On Dec. 3, 2014, 11:27 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28323/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 11:27 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa > 3rdparty/libprocess/src/libevent_poll.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/28323/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
