----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28322/#review63718 -----------------------------------------------------------
Looks good - astonishing how much simpler the libevent clock implementation is. However, it is a bit dense - can you easen it up a bit with some comments on how you are using the libevent api? 3rdparty/libprocess/src/libevent_clock.cpp <https://reviews.apache.org/r/28322/#comment106010> For those of us who doesn't speak libevent fully, what's going on here? :-) 3rdparty/libprocess/src/libevent_clock.cpp <https://reviews.apache.org/r/28322/#comment105999> s/nullptr/NULL/ 3rdparty/libprocess/src/libevent_clock.cpp <https://reviews.apache.org/r/28322/#comment105998> Can you expand a little bit on the conversion? Maybe worth generalizing? 3rdparty/libprocess/src/libevent_clock.cpp <https://reviews.apache.org/r/28322/#comment105997> Same here - Niklas Nielsen On Dec. 3, 2014, 11:50 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28322/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 11:50 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/src/libevent.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/28322/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
