----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28322/#review63910 -----------------------------------------------------------
3rdparty/libprocess/src/libevent.cpp <https://reviews.apache.org/r/28322/#comment106236> See comments in previous review that added EventLoop::delay for libev. 3rdparty/libprocess/src/libevent.cpp <https://reviews.apache.org/r/28322/#comment106235> Can this return an error? 3rdparty/libprocess/src/libevent.cpp <https://reviews.apache.org/r/28322/#comment106231> Seconds seconds = Seconds(tval.tv_sec) + Microseconds(tval.tv_usec); return seconds.value(); 3rdparty/libprocess/src/libevent.cpp <https://reviews.apache.org/r/28322/#comment106233> Can 'timer_ev' be NULL? Do we need to check? - Benjamin Hindman On Dec. 3, 2014, 10:48 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28322/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 10:48 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/src/libevent.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/28322/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
