----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28824/#review64653 -----------------------------------------------------------
src/master/hierarchical_allocator_process.hpp <https://reviews.apache.org/r/28824/#comment107443> Hum, just realized another issue. What if both the reserved resources for a role and star resources are not allocatable, but combining them makes it allocatable? The new code won't make an allocation while the old code will? Looks like a bug. The same issue applies to ```isFiltered```. Thoughs? - Jie Yu On Dec. 8, 2014, 10:11 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28824/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2014, 10:11 p.m.) > > > Review request for mesos, Jie Yu and Michael Park. > > > Bugs: MESOS-2176 > https://issues.apache.org/jira/browse/MESOS-2176 > > > Repository: mesos-git > > > Description > ------- > > Per MESOS-2176: > > (1) The top level role sorter always excludes reserved resources. > (2) The intra-role framework sorter always includes both reserved and > unreserved resources. > > > Diffs > ----- > > include/mesos/resources.hpp 10777a62492e4a3333d764e0f75c064694e054d1 > src/common/resources.cpp 535a0eab6377b9ae63c960cdb05978647f667d5e > src/master/hierarchical_allocator_process.hpp > f18346f435a16d1e6243315bffa00fabd164e310 > src/master/sorter.hpp aabdd0d3755be2534e2f6cae13976277ca39deb1 > src/tests/hierarchical_allocator_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/28824/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
