> On Dec. 12, 2014, 7:35 p.m., Jie Yu wrote: > > src/master/hierarchical_allocator_process.hpp, line 757 > > <https://reviews.apache.org/r/28824/diff/2/?file=790057#file790057line757> > > > > Why changed it to +=?
It was for symmetry: ``` offerable[frameworkId][slaveId] += resources; slaves[slaveId].available -= resources; ``` Looked more clear to me than: ``` offerable[frameworkId][slaveId] = resources; slaves[slaveId].available -= resources; ``` But I'll change it back, since the latter perhaps makes the "coarse-grained" nature of the allocation more clear. I'll add a comment about that. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28824/#review64958 ----------------------------------------------------------- On Dec. 12, 2014, 7:21 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28824/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2014, 7:21 a.m.) > > > Review request for mesos, Jie Yu and Michael Park. > > > Bugs: MESOS-2176 > https://issues.apache.org/jira/browse/MESOS-2176 > > > Repository: mesos-git > > > Description > ------- > > Per MESOS-2176: > > (1) The top level role sorter always excludes reserved resources. > (2) The intra-role framework sorter always includes both reserved and > unreserved resources. > > > Diffs > ----- > > src/master/hierarchical_allocator_process.hpp > 610fcd97b76f8581cb3253237ab0948420b6949a > src/master/sorter.hpp 818967f5ca2aad91d9035108b7cde223e4e626ba > src/tests/hierarchical_allocator_tests.cpp > 7e3dcd5ae27dcf4f0358fe62d51916cb7d522c09 > > Diff: https://reviews.apache.org/r/28824/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
