> On Dec. 8, 2014, 10:48 p.m., Jie Yu wrote: > > src/master/master.cpp, lines 4428-4431 > > <https://reviews.apache.org/r/28812/diff/1/?file=785774#file785774line4428> > > > > I got confused here. I need to dig into the ticket to understand what's > > going on here. Also, this does not like a TODO to me (since the allocator > > will be in consistent state after 'removeTask' is called below), maybe a > > NOTE is more appropriate?
Re-wrote the existing comment (since it was wrong anyway), let me know if it makes more sense now Jie! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28812/#review64296 ----------------------------------------------------------- On Dec. 11, 2014, 1:45 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28812/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2014, 1:45 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > The existing comment is not accurate, given MESOS-621. > > > Diffs > ----- > > src/master/master.cpp 1cf2074b78e260bcccf96f4383bc4747b1e75063 > > Diff: https://reviews.apache.org/r/28812/diff/ > > > Testing > ------- > > N/A > > > Thanks, > > Ben Mahler > >
