> On Dec. 11, 2014, 7:57 p.m., Jie Yu wrote: > > src/master/master.cpp, lines 4537-4539 > > <https://reviews.apache.org/r/28812/diff/2/?file=788903#file788903line4537> > > > > I think your comments are fine. The missleading part is the function > > "recoverResources". It actually performs two things: > > 1) put resources back to slave.avalable so that those resources can be > > allocated to others > > 2) update sorters so that frameworks/roles no longer get charged for > > those resources > > > > To me, (1) is the "recover" part. The fact that you wanna call > > "recoverResources" below in this function is actually for (2).
Yeah, what you describe is the MESOS-621 issue. Ok, I'll update this to be a bit more descriptive, and to reference the ticket. Thanks! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28812/#review64782 ----------------------------------------------------------- On Dec. 11, 2014, 1:45 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28812/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2014, 1:45 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > The existing comment is not accurate, given MESOS-621. > > > Diffs > ----- > > src/master/master.cpp 1cf2074b78e260bcccf96f4383bc4747b1e75063 > > Diff: https://reviews.apache.org/r/28812/diff/ > > > Testing > ------- > > N/A > > > Thanks, > > Ben Mahler > >
