----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29033/#review65101 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/29033/#comment108043> s/net_tcp_total_active_connections/net_tcp_active_connections/ Also, no need for the comments because it's pretty clear from the variable name. include/mesos/mesos.proto <https://reviews.apache.org/r/29033/#comment108044> Ditto for removing the comments. s/net_tcp_total_tw_connections/net_tcp_time_wait_connections/ src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/29033/#comment108055> Consider using tokenize instead of split. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/29033/#comment108056> Ditto. Consider using tokenize instead of split. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/29033/#comment108057> Why doing this change? I would suggest keep the original code because it implies a ALL-OR-NOTHING semantics for those rtt statistics. src/slave/flags.hpp <https://reviews.apache.org/r/29033/#comment108049> I would suggest using two separate flags: ``` network_enable_socket_statistics_details network_enable_socket_statistics_summary ``` The benefit is that you can choose to turn off all of them (which we will use initially). - Jie Yu On Dec. 15, 2014, 3:26 a.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29033/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2014, 3:26 a.m.) > > > Review request for mesos, Dominic Hamon, Ian Downes, Jie Yu, and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > While we are still working to make RTT less expensive to get, expose total > number of tcp connections in use and in TIME_WAIT. > > > Diffs > ----- > > include/mesos/mesos.proto 540071d > src/slave/containerizer/isolators/network/port_mapping.hpp f1e2352 > src/slave/containerizer/isolators/network/port_mapping.cpp 2d81336 > src/slave/flags.hpp 670997d > src/tests/port_mapping_tests.cpp eb82993 > > Diff: https://reviews.apache.org/r/29033/diff/ > > > Testing > ------- > > expanded a test case to test PortMappingStatistics. > > > Thanks, > > Chi Zhang > >
