----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29033/#review66745 -----------------------------------------------------------
src/slave/containerizer/isolators/network/port_mapping.hpp <https://reviews.apache.org/r/29033/#comment110352> No need. See my comments below. src/slave/containerizer/isolators/network/port_mapping.hpp <https://reviews.apache.org/r/29033/#comment110353> Ditto. src/slave/containerizer/isolators/network/port_mapping.hpp <https://reviews.apache.org/r/29033/#comment110351> I don't think those functions need to be exposed (given that the tests use these interfaces are not necessary, please see my comments below). src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/29033/#comment110354> Please make it static. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/29033/#comment110355> Ditto. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/29033/#comment110356> Please insert a blank line after that. Here and everywhere else. src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/29033/#comment110357> s/portMappingStatisticsHelper/statisticsHelper/ Since the class is named as PortMapping... src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/29033/#comment110358> I don't think those tests are necessary since the code should have been tested in the following test. - Jie Yu On Jan. 5, 2015, 8:51 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29033/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2015, 8:51 p.m.) > > > Review request for mesos, Dominic Hamon, Ian Downes, Jie Yu, and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > While we are still working to make RTT less expensive to get, expose total > number of tcp connections in use and in TIME_WAIT. > > > Diffs > ----- > > include/mesos/mesos.proto 540071d > src/slave/containerizer/isolators/network/port_mapping.hpp f1e2352 > src/slave/containerizer/isolators/network/port_mapping.cpp 2d81336 > src/slave/flags.hpp 670997d > src/tests/port_mapping_tests.cpp eb82993 > > Diff: https://reviews.apache.org/r/29033/diff/ > > > Testing > ------- > > expanded a test case to test PortMappingStatistics. > > > Thanks, > > Chi Zhang > >
