----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29071/#review65162 -----------------------------------------------------------
src/slave/slave.cpp <https://reviews.apache.org/r/29071/#comment108150> so webui_log overrides log_dir? should check if both are set and error. src/slave/slave.cpp <https://reviews.apache.org/r/29071/#comment108149> might want to check that the file exists, as per the log_dir stanza above. src/webui/master/static/js/controllers.js <https://reviews.apache.org/r/29071/#comment108151> or 'webui_log' - Dominic Hamon On Dec. 15, 2014, 4:51 p.m., David Robinson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29071/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2014, 4:51 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-2193 > https://issues.apache.org/jira/browse/MESOS-2193 > > > Repository: mesos-git > > > Description > ------- > > added webui_log option > > > Diffs > ----- > > src/master/flags.hpp 1cea50c02f3ad7de1e1ae91d65d1accdb9af7b03 > src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8 > src/master/master.cpp 0f55a5cc2d6845cbaace718a48f771d80aad0e6e > src/slave/flags.hpp 670997dc3a702cd5edf33f2e5824c5e4dfe4ecef > src/slave/http.cpp d1cf8a68fab9a2df44f6c753683ad37fd4b1a1f9 > src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b > src/webui/master/static/js/controllers.js > 41a70a80442501a2bf7b217939dbe504662941d2 > > Diff: https://reviews.apache.org/r/29071/diff/ > > > Testing > ------- > > Ran locally. > > > Thanks, > > David Robinson > >
