> On Dec. 16, 2014, 12:58 a.m., Dominic Hamon wrote:
> > src/slave/slave.cpp, line 459
> > <https://reviews.apache.org/r/29071/diff/1/?file=792487#file792487line459>
> >
> > might want to check that the file exists, as per the log_dir stanza
> > above.
The stanza above just returns a filename (created from log_dir, log level etc),
it doesn't check that the file exists. FilesProcess::attach is where file
existance check occurs:
Future<Nothing> FilesProcess::attach(const string& path, const string& name)
{
Result<string> result = os::realpath(path);
if (!result.isSome()) {
return Failure(
"Failed to get realpath of '" + path + "': " +
(result.isError()
? result.error()
: "No such file or directory"));
}
// Make sure we have permissions to read the file/dir.
...
> On Dec. 16, 2014, 12:58 a.m., Dominic Hamon wrote:
> > src/slave/slave.cpp, line 446
> > <https://reviews.apache.org/r/29071/diff/1/?file=792487#file792487line446>
> >
> > so webui_log overrides log_dir? should check if both are set and error.
Done.
> On Dec. 16, 2014, 12:58 a.m., Dominic Hamon wrote:
> > src/webui/master/static/js/controllers.js, line 405
> > <https://reviews.apache.org/r/29071/diff/1/?file=792488#file792488line405>
> >
> > or 'webui_log'
Done.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29071/#review65162
-----------------------------------------------------------
On Dec. 16, 2014, 12:51 a.m., David Robinson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29071/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2014, 12:51 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2193
> https://issues.apache.org/jira/browse/MESOS-2193
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> added webui_log option
>
>
> Diffs
> -----
>
> src/master/flags.hpp 1cea50c02f3ad7de1e1ae91d65d1accdb9af7b03
> src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
> src/master/master.cpp 0f55a5cc2d6845cbaace718a48f771d80aad0e6e
> src/slave/flags.hpp 670997dc3a702cd5edf33f2e5824c5e4dfe4ecef
> src/slave/http.cpp d1cf8a68fab9a2df44f6c753683ad37fd4b1a1f9
> src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
> src/webui/master/static/js/controllers.js
> 41a70a80442501a2bf7b217939dbe504662941d2
>
> Diff: https://reviews.apache.org/r/29071/diff/
>
>
> Testing
> -------
>
> Ran locally.
>
>
> Thanks,
>
> David Robinson
>
>
