> On Dec. 17, 2014, 1:44 a.m., Ben Mahler wrote: > > include/mesos/resources.hpp, line 113 > > <https://reviews.apache.org/r/29134/diff/1/?file=793483#file793483line113> > > > > Hm.. I must be missing something subtle here. Why is this necessary to > > point out and differentiate with _contains? > > > > Is it possible for a Resources object to contain an invalid Resource?
Are you suggesting removing the NOTE? - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29134/#review65272 ----------------------------------------------------------- On Dec. 17, 2014, 1:36 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29134/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2014, 1:36 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/resources.hpp 296553a > src/common/resources.cpp 9bf7ae9 > > Diff: https://reviews.apache.org/r/29134/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
