> On Dec. 18, 2014, 12:16 a.m., Ben Mahler wrote: > > src/common/resources.cpp, line 439 > > <https://reviews.apache.org/r/29134/diff/1/?file=793484#file793484line439> > > > > Can you add a NOTE here: > > > > // NOTE: We must validate 'that' because invalid resources can lead to > > false positives here, and are mesos::contains assumes resources are valid. > > // E.g. "cpus:-1" will always return true.
Done. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29134/#review65396 ----------------------------------------------------------- On Dec. 17, 2014, 1:36 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29134/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2014, 1:36 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/resources.hpp 296553a > src/common/resources.cpp 9bf7ae9 > > Diff: https://reviews.apache.org/r/29134/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
