----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29177/#review65408 -----------------------------------------------------------
Ship it! Could you add a test as well before you commit this? :) include/mesos/resources.hpp <https://reviews.apache.org/r/29177/#comment108521> s/;/. Mind adding a TODO here? // TODO(jieyu): Consider extending the Filter mechanism in resources.cpp, // which would allow us to pull out this kind of logic. E.g.: // // Resources persistentDisks = PersistentDiskFilter().apply(resources); - Ben Mahler On Dec. 17, 2014, 8:29 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29177/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2014, 8:29 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > Added a method in Resources to return all persistent disks. > > > Diffs > ----- > > include/mesos/resources.hpp 16d054641f37dfa50446b2759843d05dcec04d61 > src/common/resources.cpp 2bc2f0a74ed09320984ea8796d6c8a52ea29ddd2 > > Diff: https://reviews.apache.org/r/29177/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
