> On Dec. 18, 2014, 12:35 a.m., Ben Mahler wrote: > > include/mesos/resources.hpp, line 126 > > <https://reviews.apache.org/r/29177/diff/1/?file=795047#file795047line126> > > > > s/;/. > > > > Mind adding a TODO here? > > > > // TODO(jieyu): Consider extending the Filter mechanism in > > resources.cpp, > > // which would allow us to pull out this kind of logic. E.g.: > > // > > // Resources persistentDisks = PersistentDiskFilter().apply(resources);
Done. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29177/#review65408 ----------------------------------------------------------- On Dec. 17, 2014, 8:29 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29177/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2014, 8:29 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > Added a method in Resources to return all persistent disks. > > > Diffs > ----- > > include/mesos/resources.hpp 16d054641f37dfa50446b2759843d05dcec04d61 > src/common/resources.cpp 2bc2f0a74ed09320984ea8796d6c8a52ea29ddd2 > > Diff: https://reviews.apache.org/r/29177/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
