----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29337/#review65847 -----------------------------------------------------------
Bad patch! Reviews applied: [29327, 29328, 29329, 29330, 29331, 29332, 29333, 29334, 29335, 29336, 29337] Failed command: ./support/apply-review.sh -n -r 29337 Error: 2014-12-23 00:01:32 URL:https://reviews.apache.org/r/29337/diff/raw/ [43123/43123] -> "29337.patch" [1] error: patch failed: src/tests/docker_containerizer_tests.cpp:2581 error: src/tests/docker_containerizer_tests.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On Dec. 22, 2014, 11:54 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29337/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2014, 11:54 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Launch docker container and log through docker executor. > Also need to modify tests to wait for docker container to run after receiving > TASK_RUNNING, since in the docker executor it launches the container > non-detached, and we don't know when the container is actually running after > the subprocess. > > > Diffs > ----- > > src/docker/docker.hpp 3ebbc1f82ac388c4d348417ae33ccc2a56ad3f28 > src/docker/docker.cpp 3a485a28d4b1ac3fcbce2e89c7d52b097886921a > src/docker/executor.cpp PRE-CREATION > src/slave/containerizer/docker.hpp 28ebc6272cd68167fc9a0898fd8eb9d53890b815 > src/slave/containerizer/docker.cpp 19a6ea2b5342abe4bf10cf4ea2d5d756df9f8665 > src/tests/docker_containerizer_tests.cpp > bed2d1005647d62b3ec013315b883d33990b896e > > Diff: https://reviews.apache.org/r/29337/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Timothy Chen > >
