----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29337/#review69545 -----------------------------------------------------------
src/docker/executor.cpp <https://reviews.apache.org/r/29337/#comment114231> grammar src/docker/executor.cpp <https://reviews.apache.org/r/29337/#comment114232> "mapped in" -> "mapped into". Otherwise I would not know what it could possibly mean. src/tests/docker_containerizer_tests.cpp <https://reviews.apache.org/r/29337/#comment114234> This can be factored out. We have closures... src/tests/docker_containerizer_tests.cpp <https://reviews.apache.org/r/29337/#comment114235> What's the reason for this timed waiting? Hacky stuff like this deserves an explanation in a comment. src/tests/docker_containerizer_tests.cpp <https://reviews.apache.org/r/29337/#comment114236> 3rd time similar code that can be factored out. This is a fairly complex change. I will get back to it again, and make more comments then. - Bernd Mathiske On Jan. 16, 2015, 5:37 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29337/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2015, 5:37 p.m.) > > > Review request for mesos, Benjamin Hindman and Bernd Mathiske. > > > Repository: mesos-git > > > Description > ------- > > Launch docker container and log through docker executor. > Also need to modify tests to wait for docker container to run after receiving > TASK_RUNNING, since in the docker executor it launches the container > non-detached, and we don't know when the container is actually running after > the subprocess. > > > Diffs > ----- > > src/docker/docker.hpp 3ebbc1f > src/docker/docker.cpp 3a485a2 > src/docker/executor.cpp PRE-CREATION > src/slave/containerizer/docker.hpp b7bf54a > src/slave/containerizer/docker.cpp 5f4b4ce > src/tests/docker_containerizer_tests.cpp 2105ae2 > > Diff: https://reviews.apache.org/r/29337/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Timothy Chen > >
