----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28975/#review66079 -----------------------------------------------------------
Patch looks great! Reviews applied: [28975] All tests passed. - Mesos ReviewBot On Dec. 25, 2014, 6:27 a.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28975/ > ----------------------------------------------------------- > > (Updated Dec. 25, 2014, 6:27 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-2173 > https://issues.apache.org/jira/browse/MESOS-2173 > > > Repository: mesos-git > > > Description > ------- > > Changed env var ensemble into one env var containing JSON, parsing this to > protobuf for use. Adapted fetcher tests. > > > Diffs > ----- > > include/mesos/fetcher/fetcher.hpp PRE-CREATION > include/mesos/fetcher/fetcher.proto PRE-CREATION > src/Makefile.am 6f132b5a66e117c2a907763217bfafe1fce1b7a0 > src/launcher/fetcher.cpp 2f54d9e061d6b56a9b9cd857e5a908fee2847e68 > src/slave/containerizer/fetcher.hpp > 12b81b1065b6b0a0368ebd44326c75c1d4e4ba79 > src/slave/containerizer/fetcher.cpp > d702a9ccc15b21ba26fb9356aa69da15dfd5973e > src/tests/fetcher_tests.cpp 9e48392d31c886bad60abc8999fe293f55f589b0 > > Diff: https://reviews.apache.org/r/28975/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Bernd Mathiske > >
