----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28975/#review66107 -----------------------------------------------------------
Ship it! I'll get this committed after some minor cleanups! src/Makefile.am <https://reviews.apache.org/r/28975/#comment109468> libmesos_la_SOURCES = \ $(MESOS_PROTO) $(CONTAINERIZER_PROTO) $(FETCHER_PROTO) $(SCHEDULER_PROTO) src/launcher/fetcher.cpp <https://reviews.apache.org/r/28975/#comment109462> Newline between these please. src/slave/containerizer/fetcher.cpp <https://reviews.apache.org/r/28975/#comment109467> Let's move this down to the bottom now, closer to where we use it and return it. Eventually we can use some C++11 to simplify the return statement further. src/slave/containerizer/fetcher.cpp <https://reviews.apache.org/r/28975/#comment109463> +2 not +4 here please, but that should all fit on one line right? src/tests/fetcher_tests.cpp <https://reviews.apache.org/r/28975/#comment109464> ASSERT_SOME(parse); Here and all the other tests please! src/tests/fetcher_tests.cpp <https://reviews.apache.org/r/28975/#comment109465> ASSERT_SOME(fetcherInfo); Here and all the other tests please! src/tests/fetcher_tests.cpp <https://reviews.apache.org/r/28975/#comment109466> You swapped the ordering here, you want to expected value first, then the actual value: EXPECT_EQ(directory, fetcherInfo.get().work_directory()); Here and all the other tests too please! - Benjamin Hindman On Dec. 25, 2014, 6:27 a.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28975/ > ----------------------------------------------------------- > > (Updated Dec. 25, 2014, 6:27 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-2173 > https://issues.apache.org/jira/browse/MESOS-2173 > > > Repository: mesos-git > > > Description > ------- > > Changed env var ensemble into one env var containing JSON, parsing this to > protobuf for use. Adapted fetcher tests. > > > Diffs > ----- > > include/mesos/fetcher/fetcher.hpp PRE-CREATION > include/mesos/fetcher/fetcher.proto PRE-CREATION > src/Makefile.am 6f132b5a66e117c2a907763217bfafe1fce1b7a0 > src/launcher/fetcher.cpp 2f54d9e061d6b56a9b9cd857e5a908fee2847e68 > src/slave/containerizer/fetcher.hpp > 12b81b1065b6b0a0368ebd44326c75c1d4e4ba79 > src/slave/containerizer/fetcher.cpp > d702a9ccc15b21ba26fb9356aa69da15dfd5973e > src/tests/fetcher_tests.cpp 9e48392d31c886bad60abc8999fe293f55f589b0 > > Diff: https://reviews.apache.org/r/28975/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Bernd Mathiske > >
