----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29533/#review66739 -----------------------------------------------------------
Mind adding some tests for the stringification? :) 3rdparty/libprocess/3rdparty/stout/include/stout/url.hpp <https://reviews.apache.org/r/29533/#comment110341> Shouldn't this be an output stream operator instead of stringify? (e.g. Duration / Bytes). That way, you can do both of the following: ``` stringify(url); LOG(INFO) << url; ``` As opposed to requiring the explicit stringify call: ``` LOG(INFO) << stringify(url); ``` 3rdparty/libprocess/3rdparty/stout/include/stout/url.hpp <https://reviews.apache.org/r/29533/#comment110342> const & ? - Ben Mahler On Jan. 2, 2015, 4:46 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29533/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2015, 4:46 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/url.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/29533/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
