> On Jan. 5, 2015, 2:50 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/url.hpp, lines 28-29 > > <https://reviews.apache.org/r/29533/diff/1/?file=805385#file805385line28> > > > > Is this complete? It doesn't look like it supports what we currently > > have in src/zookeeper/url.hpp: > > > > ``` > > // Describes a ZooKeeper URL of the form: > > // > > // zk://username:password@servers/path > > // > > // Where username:password is for the 'digest' scheme (see ZooKeeper > > // documentation regarding "access controls using ACLs") and servers > > // is of the form: > > // > > // host1:port1,host2:port2,host3:port3 > > // > > // Note that in the future we may want to support authentication > > // mechanisms other than 'digest' and have a URL of the following > > // form. > > // > > // zk://scheme:credentials@servers/path > > ``` > > Niklas Nielsen wrote: > Should we follow: http://tools.ietf.org/html/rfc3986 ? True URL parsing > is tricky.
Or write a shim on an existing library instead of rewriting: http://uriparser.sourceforge.net/ - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29533/#review66742 ----------------------------------------------------------- On Jan. 1, 2015, 8:46 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29533/ > ----------------------------------------------------------- > > (Updated Jan. 1, 2015, 8:46 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/url.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/29533/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
