> On Jan. 8, 2015, 10:17 p.m., Timothy Chen wrote: > > src/slave/containerizer/isolator.hpp, line 19 > > <https://reviews.apache.org/r/29603/diff/1/?file=807156#file807156line19> > > > > why __MESOS__?
The pattern here is that we use the folder hierachy also for the include-guard-naming. Unfortunately that pattern is not consistantly used so far. We should decide now if we want to fix that (e.g. mesos.hpp guarded by __MESOS_HPP__ and not by __MESOS_MESOS_HPP__, resources.hpp guarded by __RESOURCES_HPP__ and not by __MESOS_MESOS_RESOURCES_HPP__ VS. executor.hpp guarded by __MESOS_EXECUTOR_HPP__). See https://issues.apache.org/jira/browse/MESOS-2211 - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29603/#review67304 ----------------------------------------------------------- On Jan. 6, 2015, 10:39 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29603/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2015, 10:39 p.m.) > > > Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen. > > > Bugs: MESOS-2096 > https://issues.apache.org/jira/browse/MESOS-2096 > > > Repository: mesos-git > > > Description > ------- > > [6/9] Build Mesos Modules outside Mesos source tree. > > Expose isolator.hpp to allow modules to include it directly from the Mesos > install location. > > > Diffs > ----- > > src/Makefile.am 0521f5849acc3237a8fa3970c983beab74441586 > src/examples/test_isolator_module.cpp > dc107a1315271b0275c60819c4b5aaa1f527e73c > src/module/isolator.hpp 0f71e700ed2de20bdc9a1fdad087005a14e208a8 > src/slave/containerizer/containerizer.cpp > e89511a6b89cb510029dfaf4e1aafe0145986968 > src/slave/containerizer/external_containerizer.hpp > 8363cec490a2918e08a8d30d9b8832fd1e2dd4f5 > src/slave/containerizer/isolator.hpp > e82a14201f734292a46b8816c894fa8c766dae5a > src/slave/containerizer/isolator.cpp > 90a47c4fc8ce2d1a2aa09fa9ad905b76eab74c80 > src/slave/containerizer/isolators/cgroups/cpushare.hpp > 4ded0c4678ad61742a69e14233006a448f3fc3ca > src/slave/containerizer/isolators/cgroups/mem.hpp > 2fa755571b4d21b8b13301fcfd57ae05ea66e6e6 > src/slave/containerizer/isolators/cgroups/perf_event.hpp > e511c3efe4cc4ec13cc74bdcda993477a4db2e36 > src/slave/containerizer/isolators/filesystem/shared.hpp > 727f63e16fa69293c472a4b6b95fb0be04e689c8 > src/slave/containerizer/isolators/namespaces/pid.hpp > 8da6cccff04edf11fa37f5a33648821299cf49d5 > src/slave/containerizer/isolators/network/port_mapping.hpp > f1e23526bc18b23f187c5d38e63d366cb509fff0 > src/slave/containerizer/isolators/posix.hpp > 7a667e3e30712b98484947520b58965d3b768659 > src/slave/containerizer/mesos/containerizer.hpp > 802988c90ac872b0cefa5e28f06e6fec98e8d032 > src/slave/containerizer/mesos/containerizer.cpp > 5c014ebe360b9527b3edd505d47e57a4d5ce5c52 > src/slave/state.hpp 592182b21ae2700c627f180db38ca5dc1b3c9e8a > src/tests/containerizer_tests.cpp cfe31a6b528ec44c5f4ff9eaf453c68d9e518db4 > src/tests/isolator.hpp 2c3a694fade996df6fb679e78f96876a7d32d214 > src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8 > src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc > > Diff: https://reviews.apache.org/r/29603/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Kapil Arya > >
