-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29603/
-----------------------------------------------------------
(Updated Jan. 9, 2015, 6:04 p.m.)
Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
Changes
-------
Addressed Tim's comments. Moved isolator.hpp to mesos/slave directory.
Bugs: MESOS-2096
https://issues.apache.org/jira/browse/MESOS-2096
Repository: mesos-git
Description (updated)
-------
[7/10] Build Mesos Modules outside Mesos source tree.
Expose isolator.hpp to allow modules to include it directly from the Mesos
install location.
Diffs (updated)
-----
src/Makefile.am 0521f5849acc3237a8fa3970c983beab74441586
src/examples/test_isolator_module.cpp
dc107a1315271b0275c60819c4b5aaa1f527e73c
src/exec/exec.cpp e15f834beda94664b8e95c49ea87b4d36b853e71
src/module/isolator.hpp 0f71e700ed2de20bdc9a1fdad087005a14e208a8
src/slave/containerizer/composing.cpp
a6ae817a973d49b433519beb8eda99692c203613
src/slave/containerizer/containerizer.hpp
129e60f20835f5d151701e934330b81825887af1
src/slave/containerizer/containerizer.cpp
e89511a6b89cb510029dfaf4e1aafe0145986968
src/slave/containerizer/external_containerizer.hpp
8363cec490a2918e08a8d30d9b8832fd1e2dd4f5
src/slave/containerizer/isolator.hpp e82a14201f734292a46b8816c894fa8c766dae5a
src/slave/containerizer/isolator.cpp 90a47c4fc8ce2d1a2aa09fa9ad905b76eab74c80
src/slave/containerizer/isolators/cgroups/cpushare.hpp
4ded0c4678ad61742a69e14233006a448f3fc3ca
src/slave/containerizer/isolators/cgroups/cpushare.cpp
90aabb85da452a3a508888f738379a73b7465dc6
src/slave/containerizer/isolators/cgroups/mem.hpp
2fa755571b4d21b8b13301fcfd57ae05ea66e6e6
src/slave/containerizer/isolators/cgroups/mem.cpp
71f4b9b3885ccb1c9e5ad589e65be06045030f19
src/slave/containerizer/isolators/cgroups/perf_event.hpp
e511c3efe4cc4ec13cc74bdcda993477a4db2e36
src/slave/containerizer/isolators/cgroups/perf_event.cpp
6f67164d3963769148fb1749d1d590b7b2999fdb
src/slave/containerizer/isolators/filesystem/shared.hpp
727f63e16fa69293c472a4b6b95fb0be04e689c8
src/slave/containerizer/isolators/filesystem/shared.cpp
5c347af803bf512698dd580d6533c0103b289427
src/slave/containerizer/isolators/namespaces/pid.hpp
8da6cccff04edf11fa37f5a33648821299cf49d5
src/slave/containerizer/isolators/namespaces/pid.cpp
fdd430e946c386e37ffc5b24907063180cddac17
src/slave/containerizer/isolators/network/port_mapping.hpp
f1e23526bc18b23f187c5d38e63d366cb509fff0
src/slave/containerizer/isolators/network/port_mapping.cpp
2d813369bd844ad743f7d3f18dbab29b2467f2c8
src/slave/containerizer/isolators/posix.hpp
7a667e3e30712b98484947520b58965d3b768659
src/slave/containerizer/launcher.hpp 18b3546a5e51e8a3819bca11630f699a0aadf762
src/slave/containerizer/mesos/containerizer.hpp
802988c90ac872b0cefa5e28f06e6fec98e8d032
src/slave/containerizer/mesos/containerizer.cpp
5c014ebe360b9527b3edd505d47e57a4d5ce5c52
src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6
src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
src/slave/state.hpp 592182b21ae2700c627f180db38ca5dc1b3c9e8a
src/slave/state.cpp 5e73dbc0e5ede68f3b4f592ecb79a009b76494f5
src/slave/status_update_manager.hpp 1c8a54ea510de084c0f35016e83788d441d3b813
src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4
src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
src/tests/containerizer_tests.cpp cfe31a6b528ec44c5f4ff9eaf453c68d9e518db4
src/tests/docker_containerizer_tests.cpp
2105ae2c410f01e7e0d10241d5c00df143fd3439
src/tests/isolator.hpp 2c3a694fade996df6fb679e78f96876a7d32d214
src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8
src/tests/module.cpp 6cec1cbafe4750cff005191c51ce7c08149c18f4
src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc
src/tests/paths_tests.cpp 8e112647293d929c6463815837e880f290fd3e36
src/tests/port_mapping_tests.cpp eb82993520f7e8de46cf6cf6b638a9286aa9b3df
src/tests/slave_recovery_tests.cpp cd4a398ef680b5694cb6069b8e2ca4e2c05911d1
Diff: https://reviews.apache.org/r/29603/diff/
Testing
-------
make check.
Thanks,
Kapil Arya
